Skip to content

Analytics Hub: Product Card error state #8304

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Dec 5, 2022
Merged

Analytics Hub: Product Card error state #8304

merged 4 commits into from
Dec 5, 2022

Conversation

@Ecarrion
Copy link
Contributor

@Ecarrion Ecarrion commented Dec 2, 2022

closes #8199

Why

This PR adds a text label to indicate that there was an error loading the items sold list. Following the pattern already introduced.

Screenshots

Simulator Screen Shot - iPhone 14 Pro - 2022-12-02 at 15 42 50

Testing Steps

  • Navigate to the analytics dashboard
  • Turn off any internet connection
  • Tap on the "See More" button
  • See that the product list contains an error label.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@Ecarrion Ecarrion added the category: tracks Related to analytics, including Tracks Events. label Dec 2, 2022
@Ecarrion Ecarrion added this to the 11.6 milestone Dec 2, 2022
@wpmobilebot
Copy link
Collaborator

wpmobilebot commented Dec 2, 2022 •
edited
Loading

You can test the changes from this Pull Request by:
  • Clicking here or scanning the QR code below to access App Center
  • Then installing the build number pr8304-2a51b29 on your iPhone

If you need access to App Center, please ask a maintainer to add you.

@Ecarrion Ecarrion force-pushed the issue/8199-empty-state branch from 17c4d44 to 2a51b29 Compare December 3, 2022 01:57
Base automatically changed from issue/8199-fetch-top-performers-data to trunk December 3, 2022 02:21
@Ecarrion Ecarrion linked an issue Dec 3, 2022 that may be closed by this pull request
[Analytics Hub] Add Top Performers list to Products Analytics card #8199
Closed
@rachelmcr rachelmcr self-assigned this Dec 5, 2022
rachelmcr
rachelmcr approved these changes Dec 5, 2022
View reviewed changes
Copy link
Contributor

@rachelmcr rachelmcr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@Ecarrion Ecarrion merged commit 86f10d1 into trunk Dec 5, 2022
@Ecarrion Ecarrion deleted the issue/8199-empty-state branch December 5, 2022 12:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ealeksandrov ealeksandrov Awaiting requested review from ealeksandrov

@ThomazFB ThomazFB Awaiting requested review from ThomazFB

1 more reviewer

@rachelmcr rachelmcr rachelmcr approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@rachelmcr rachelmcr

Labels

category: tracks Related to analytics, including Tracks Events.

Projects

None yet

Milestone

11.6

Development

Successfully merging this pull request may close these issues.

[Analytics Hub] Add Top Performers list to Products Analytics card

4 participants

@Ecarrion @wpmobilebot @rachelmcr